Fix inaccuracy about NaN sign bit - #44707
Merged
Merged
Conversation
github-actions
Bot
added
Content:JS
Josh-Cena
requested changes
Jul 14, 2026
Josh-Cena
reviewed
Jul 20, 2026
Contributor
|
Preview URLs (1 page) |
estelle
pushed a commit
to estelle/content
that referenced
this pull request
Jul 28, 2026
* Fix inaccuracy with NaN sign bit * Update sign bit * Apply suggestion from @Josh-Cena --------- Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Previously this example claimed that the example code was changing the sign bit of the float, which doesn't effect NaN values. However, the example was actually modifying the fraction component (which also doesn't affect NaN values).
These changes correct that inaccuracy by being less specific about why the bit change still results in a NaN value.
Additional details
https://en.wikipedia.org/wiki/NaN#Encoding
Related issues and pull requests