Merged
Conversation
Collaborator
Author
|
Given that we've hit #340 quite a few times now, do we want to just skip the multi-objective NSGA2 tests here until that's sorted? |
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
===========================================
- Coverage 83.97% 72.29% -11.68%
===========================================
Files 22 22
Lines 3363 3364 +1
===========================================
- Hits 2824 2432 -392
- Misses 539 932 +393 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcomangano
previously approved these changes
May 3, 2023
lamkina
previously approved these changes
May 4, 2023
sseraj
reviewed
May 4, 2023
Collaborator
Author
|
The RTD failure is tracked at readthedocs/readthedocs#10290, we should be able to safely ignore it. |
sseraj
approved these changes
May 4, 2023
marcomangano
approved these changes
May 4, 2023
Collaborator
|
I will have @eirikurj merging this because I do not have the authority to override the required docs test |
Collaborator
Author
|
I'm gonna exercise my power before they're gone :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This test has caused problems in the past and now it's caused one conda-forge build to fail. I think it's probably best to just remove this time, don't think it's adding much value anyways.
Expected time until merged
Not urgent.
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable