flush streams and files before/after optimization#403
Merged
marcomangano merged 1 commit intomainfrom Jun 5, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 74.15% 74.33% +0.17%
==========================================
Files 22 22
Lines 3297 3300 +3
==========================================
+ Hits 2445 2453 +8
+ Misses 852 847 -5 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
sseraj
approved these changes
Jun 4, 2024
marcomangano
approved these changes
Jun 5, 2024
Collaborator
marcomangano
left a comment
There was a problem hiding this comment.
LGTM, I will take a look at the other PR, let's talk offline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The idea is that,
stdoutandstderrbefore calling the optimizer, in case prints from the runscript are bufferedI know we can and should do this for all optimizers, I actually tried to refactor some stuff into "pre-optimization" and "post-optimization" functions shared across all optimizers. But, I stumbled across #402 which means I couldn't actually verify what I was doing with the
dummyConstraintwas not introducing bugs. We can come back to it after that stuff is all cleaned up.Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable