add Options.SetAllowConcurrentMemtableWrites() accessor#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 5.0.2 rocksdb release added an assertion that will throw an exception if the memtable doesn't support concurrent writes but the allow_concurrent_memtable_write is set to its default value of true.
Sadly, if you call Options.OptimizeForPointLookup, it changes the memtable implementation to one that doesn't support concurrent writes, and since gorocksdb doesn't currently expose a setter for allow_concurrent_memtable_write there's no way to use OptimizeForPointLookup without crashing.
This is especially relevant to us because the embedded rocksdb build (from the cockroachdb c-rocksdb) repo just updated to 5.0.2, which is great because it fixed tecbot#71.
Anyway, this commit just adds a SetAllowConcurrentMemtableWrites(allow bool) method to the Options struct, and a couple comments to let people know they should use it with OptimizeForPointLookup