refactor PersistentPubSub - #185
Merged
Merged
Conversation
The impetus for this change was issue #184, but after reviewing the code I decided it needed a larger refactor just out of principal. The original code was written to not use a central go-routine out of a desire for simplicity, but in the end it ended up still needing go-routines, and the interacting between them and the locks was anything but simple. The new code has a simple go-routine loop which acts in an RPC pattern, while also monitoring the underlying PubSubConn. It's much easier to think about than the old code, and not as buggy.
nussjustin
approved these changes
Feb 13, 2020
nussjustin
left a comment
nussjustin
left a comment
Contributor
There was a problem hiding this comment.
LGTM
This is so much easier to read than the old code.
kataras
added a commit
to kataras/neffos
that referenced
this pull request
Apr 28, 2020
LeeEirc
pushed a commit
to LeeEirc/neffos
that referenced
this pull request
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impetus for this change was issue #184, but after reviewing the code
I decided it needed a larger refactor just out of principal. The
original code was written to not use a central go-routine out of a
desire for simplicity, but in the end it ended up still needing
go-routines, and the interacting between them and the locks was anything
but simple.
The new code has a simple go-routine loop which acts in an RPC pattern,
while also monitoring the underlying PubSubConn. It's much easier to
think about than the old code, and not as buggy.