Skip to content

French translation V2#10301

Merged
kodiakhq[bot] merged 5 commits intomedusajs:developfrom
MrCasquette:french-translation
Nov 27, 2024
Merged

French translation V2#10301
kodiakhq[bot] merged 5 commits intomedusajs:developfrom
MrCasquette:french-translation

Conversation

@MrCasquette
Copy link
Contributor

This PR improves the French translations already submitted.

  • Corrected missing translations.
  • Ensured the JSON structure matches the English version.
  • Verified consistency across all keys.

The file is very large and it's hard to make sure everything is right.

The previous Similar PR is Add french trad in i18n translations #9885

Let me know if additional changes are needed! Happy to help :)

@MrCasquette MrCasquette requested a review from a team as a code owner November 26, 2024 23:32
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 7bfabf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 26, 2024

@triplecasquette is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @triplecasquette

@MrCasquette
Copy link
Contributor Author

LGTM thanks @triplecasquette

I probably made an error with yarn. I'm more used to pnpm or even npm.

I saw that there were a lot of changes in the lockfile maybe the issue comes from here

@kasperkristensen
Copy link
Collaborator

LGTM thanks @triplecasquette

I probably made an error with yarn. I'm more used to pnpm or even npm.

I saw that there were a lot of changes in the lockfile maybe the issue comes from here

We use a specific version of yarn so if you don't have that version it will re-write the lock file. But I have reset it to develop so should be good now 👍

@MrCasquette
Copy link
Contributor Author

MrCasquette commented Nov 27, 2024

LGTM thanks @triplecasquette

I probably made an error with yarn. I'm more used to pnpm or even npm.
I saw that there were a lot of changes in the lockfile maybe the issue comes from here

We use a specific version of yarn so if you don't have that version it will re-write the lock file. But I have reset it to develop so should be good now 👍

Nice. :)

No relation with PR but maybe we should be able to use another package manager.
I find yarn quite long and verbose, whereas pnpm is fast and easy to use.

@kodiakhq kodiakhq bot merged commit 1b55f47 into medusajs:develop Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants