Add support for subscriber offer (requires specific version of Janus)#2
Merged
Conversation
Member
Author
|
PS: notice that this PR doesn't include any support for the new SSE (Server Side Events) functionality the draft added in the new version. While I may add that in the future, I don't have immediate plans to do that, especially considering that functionality may change considerably in upcoming versions, and hasn't really been discussed much. |
Member
Author
|
Merging, since the feature was merged in Janus too. I'll keep SSE in a PR, though, as that will need to keep track of updates in the spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the latest version of the WHEP draft removed support for server-originated SDP offers, and now forces all servers to accept offers from subscribers instead, leaving servers to generate an answer. This completely breaks compatibility with the Streaming plugin in Janus, which is used for WHEP support in this server and only supports server-originated offers.
I completely disagree with this choice, but my opinion doesn't matter, so I was forced to modify the Streaming plugin to start adding support for this new ugly mode too. This support is currently provided in a new PR, which means that if you want to test this feature, you'll have to compile Janus from the related branch, and not
master.When you do, you can test the offer-mode by passing a
offer=truequery string attribute to thewatch.htmlpage, e.g.:When
offer=trueis passed, the viewer page will prepare an offer instead of expecting one, and the WHEP server will handle it accordingly. Again, this will only work if the Janus server the WHEP server is using supports that mode: if you use other versions of Janus, it simply won't work.Please also test this with other WHEP viewers you may have, if any. My
simple-whep-serverhas not been updated yet, and I don't know when I'll do that (if I'll do it at all). Feedback would be welcome.