This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Set decimal precision - #6
Merged
Merged
Conversation
|
@rabidaudio This is clever!
|
|
@rabidaudio Released version meltano.1.1.7! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following is an example schema output by
tap-postgresfor a numeric column:This results in the following error when validating the data against the JSON Schema:
The
decimal.DivisionImpossibleerror is this issue, caused by running out of the default decimal precision when trying to runDecimal('0.000666259154868687') % Decimal('1E-38')(for verifyingmultipleOf).tap-postgresis usingmultipleOfto effectively report the scale of the column.This PR walks all new JSON Schemas, and uses
minimum,maximum, andmultipleOfto try and predict the required precision and update the decimal context appropriately.