Skip to content

CONV-111: Add dynamic settings smoke tests#119

Merged
menvil merged 1 commit into
developfrom
feature/CONV-111-add-dynamic-settings-smoke-tests
May 31, 2026
Merged

CONV-111: Add dynamic settings smoke tests#119
menvil merged 1 commit into
developfrom
feature/CONV-111-add-dynamic-settings-smoke-tests

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-111 — Add Dynamic Settings Smoke Tests

End-to-end Phase 8 smoke coverage locking in the flow up to the convert placeholder.

  • Upload → target → settings → continue reaches the convert placeholder for PNG→JPG, with no extra records created (ConversionJob proxy).
  • PNG→PDF shows different schema-driven settings than PNG→JPG (Page size vs Background color).

Tests only — no new features.

composer test (233), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Add smoke tests for the dashboard converter’s dynamic settings (CONV-111). Covers the Phase 8 flow up to the convert placeholder without creating jobs/extra records, and verifies PNG→JPG vs PNG→PDF show different schema-driven settings.

Written for commit 8af5334. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 298fa3c into develop May 31, 2026
@menvil menvil deleted the feature/CONV-111-add-dynamic-settings-smoke-tests branch May 31, 2026 17:31
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2209155f-31bd-4913-ae18-1d0ddba3d709

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-111-add-dynamic-settings-smoke-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant