Skip to content

CONV-131: Add image driver test fixtures#125

Merged
menvil merged 1 commit into
developfrom
feature/CONV-131-add-image-driver-test-fixtures
Jun 1, 2026
Merged

CONV-131: Add image driver test fixtures#125
menvil merged 1 commit into
developfrom
feature/CONV-131-add-image-driver-test-fixtures

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds Tests\Support\ImageFixture helper with png() and jpg() static methods
  • Uses intervention/image GD driver to generate real image binaries programmatically
  • Files are stored via Storage::disk('local') and work with Storage::fake()
  • Returns storage-relative paths for use in driver tests

Test plan

  • tests/Feature/Conversion/ImageFixtureTest.php — 2 tests pass
  • composer test passes (258 tests)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds an image fixture helper to programmatically generate real PNG/JPG files for driver tests (CONV-131). Improves reliability by creating images on the fly instead of bundling sample files.

  • New Features
    • Tests\Support\ImageFixture with png() and jpg() using intervention/image GD driver.
    • Saves to Storage::disk('local'), works with Storage::fake(), returns storage-relative paths.
    • Adds tests/Feature/Conversion/ImageFixtureTest.php covering PNG and JPG.

Written for commit 1d2f89a. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 891eda45-295e-4c25-8f27-3d9e35e9bbf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-131-add-image-driver-test-fixtures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 4000570 into develop Jun 1, 2026
1 check was pending
@menvil menvil deleted the feature/CONV-131-add-image-driver-test-fixtures branch June 1, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant