Skip to content

CONV-132: Test PNG to JPG driver#126

Merged
menvil merged 1 commit into
developfrom
feature/CONV-132-test-png-to-jpg-driver
Jun 1, 2026
Merged

CONV-132: Test PNG to JPG driver#126
menvil merged 1 commit into
developfrom
feature/CONV-132-test-png-to-jpg-driver

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds failing test for PngToJpgDriver (class does not exist yet — implemented in CONV-133)
  • Adds Tests\Support\ConversionContextFactory::forSourcePath() helper to build a ConversionContext without DB interaction for driver unit tests
  • Test verifies: output file exists, extension = jpg, mime = image/jpeg, size > 0

Test plan

  • Test fails with "Target class does not exist" before implementation (expected)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds a failing unit test for PngToJpgDriver per CONV-132 and introduces Tests\Support\ConversionContextFactory::forSourcePath() to build a ConversionContext without DB access for driver tests.
The test verifies the output exists, has extension jpg, mime image/jpeg, and a size > 0.

Written for commit aec16b2. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 206dfc4 into develop Jun 1, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d426d1fc-7c3a-4997-86eb-c46ad937e918

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-132-test-png-to-jpg-driver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-132-test-png-to-jpg-driver branch June 1, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant