Skip to content

CONV-133: Implement PNG to JPG driver#127

Merged
menvil merged 1 commit into
developfrom
feature/CONV-133-implement-png-to-jpg-driver
Jun 1, 2026
Merged

CONV-133: Implement PNG to JPG driver#127
menvil merged 1 commit into
developfrom
feature/CONV-133-implement-png-to-jpg-driver

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Implements PngToJpgDriver at app/Conversion/Drivers/Image/PngToJpgDriver.php
  • Uses intervention/image GD driver to decode source PNG, fill transparent areas with background color, encode to JPEG
  • Supports quality option (low/medium/high/max → 60/75/90/100) and background hex color
  • Driver returns ConversionResult and does not mutate any models

Test plan

  • tests/Feature/Conversion/Drivers/PngToJpgDriverTest.php passes (verifies file exists, extension, mime, size)
  • composer test passes (259 tests)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds PngToJpgDriver to convert PNGs to JPEG with transparency fill and quality presets. Addresses CONV-133 by providing a reliable PNG→JPG conversion path.

  • New Features
    • Uses intervention/image GD driver to decode PNG, fill transparent areas, and encode JPG.
    • Supports quality option: low/medium/high/max → 60/75/90/100 (default 85).
    • Supports background hex color for transparency fill (default #ffffff).
    • Outputs result.jpg to the provided directory and returns a ConversionResult.

Written for commit 024f712. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c0a970f-42cb-4f33-ae31-6b0a9c5336c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-133-implement-png-to-jpg-driver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 65ebd14 into develop Jun 1, 2026
1 check passed
@menvil menvil deleted the feature/CONV-133-implement-png-to-jpg-driver branch June 1, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant