Skip to content

CONV-135: Implement JPG to PNG driver#129

Merged
menvil merged 1 commit into
developfrom
feature/CONV-135-implement-jpg-to-png-driver
Jun 1, 2026
Merged

CONV-135: Implement JPG to PNG driver#129
menvil merged 1 commit into
developfrom
feature/CONV-135-implement-jpg-to-png-driver

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Implements JpgToPngDriver at app/Conversion/Drivers/Image/JpgToPngDriver.php
  • Decodes source JPG, encodes to PNG using intervention/image GD driver
  • Returns ConversionResult without mutating any models

Test plan

  • JpgToPngDriverTest passes (file exists, extension=png, mime=image/png, size>0)
  • composer test passes (260 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds JpgToPngDriver to convert JPG files to PNG using intervention/image (GD), writing the result to the output directory and returning a ConversionResult. Addresses Linear CONV-135 by adding the jpg_to_png conversion path.

  • New Features
    • Driver key: jpg_to_png.
    • Decodes source from local storage, encodes to PNG, writes result.png, and returns path, mime, extension, and size.

Written for commit 9f9ba99. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b348e83-3891-4b47-84e7-f549789390a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-135-implement-jpg-to-png-driver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit b29b1b4 into develop Jun 1, 2026
1 check was pending
@menvil menvil deleted the feature/CONV-135-implement-jpg-to-png-driver branch June 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant