CONV-144: Implement JPG to PDF driver#138
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JpgToPdfDriveratapp/Conversion/Drivers/Image/JpgToPdfDriver.phpRendersSingleImagePdftrait to avoid duplication between PNG and JPG driversPngToPdfDriverto use the same trait (same behaviour, less code)Test plan
JpgToPdfDriverTestpasses (file exists, extension=pdf, mime=application/pdf, size>0)PngToPdfDriverTeststill passes after refactorcomposer testpasses (264 tests)composer lintpasses🤖 Generated with Claude Code
Summary by cubic
Adds JPG→PDF conversion and unifies image-to-PDF rendering in a shared trait, reducing duplication while keeping PNG behavior unchanged. Fulfills CONV-144 and supports page size, orientation (including auto), margins, and fit options.
New Features
JpgToPdfDriverthat embeds the image as a base64 data URI and renders viabarryvdh/laravel-dompdf.Refactors
RendersSingleImagePdftrait for shared rendering logic; updatedPngToPdfDriverto use it with no behavior changes.Written for commit 756770b. Summary will update on new commits.