Skip to content

CONV-145: Register real image drivers#139

Merged
menvil merged 1 commit into
developfrom
feature/CONV-145-register-real-image-drivers
Jun 1, 2026
Merged

CONV-145: Register real image drivers#139
menvil merged 1 commit into
developfrom
feature/CONV-145-register-real-image-drivers

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Registers all 6 MVP real image drivers in ConverterServiceProvider (replaces empty registry placeholder)
  • Driver keys match converter capability keys from Phase 4: png_to_jpg, jpg_to_png, png_to_webp, jpg_to_webp, png_to_pdf, jpg_to_pdf

Test plan

  • ConverterDriverRegistryRealDriversTest passes — all 6 drivers resolve to correct instances
  • composer test passes (265 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Registers the 6 real image conversion drivers in the runtime ConverterDriverRegistry so MVP image conversions are discoverable by key. Fulfills Linear CONV-145 requirements for wiring up real drivers.

  • New Features
    • Registers drivers in ConverterServiceProvider for: png_to_jpg, jpg_to_png, png_to_webp, jpg_to_webp, png_to_pdf, jpg_to_pdf.
    • Adds ConverterDriverRegistryRealDriversTest to verify each key resolves to the correct driver.

Written for commit 29fc042. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 734e8f8 into develop Jun 1, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e806887e-c18d-4fb2-aff0-19159d3e4de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-145-register-real-image-drivers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-145-register-real-image-drivers branch June 1, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant