Skip to content

CONV-146: Add real driver integration smoke tests#140

Merged
menvil merged 1 commit into
developfrom
feature/CONV-146-add-real-driver-integration-smoke-tests
Jun 1, 2026
Merged

CONV-146: Add real driver integration smoke tests#140
menvil merged 1 commit into
developfrom
feature/CONV-146-add-real-driver-integration-smoke-tests

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds ProcessConversionJobRealDriverTest with 3 end-to-end smoke tests through the full queue pipeline
  • Covers PNG→JPG, JPG→WEBP, and PNG→PDF with real drivers (no FakeConverterDriver)
  • Each test verifies: job status = Completed, result_file_id is set, physical file exists in storage
  • PNG→PDF test additionally checks %PDF header
  • Tests use Storage::fake('local') + ImageFixture to generate source images programmatically

Test plan

  • All 3 smoke tests pass with real drivers
  • composer test passes (268 tests)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-146 by adding end-to-end smoke tests for the conversion queue using real drivers to verify it produces stored result files. Covers PNG→JPG, JPG→WEBP, and PNG→PDF, asserting Completed status, result_file_id, file presence in local storage, and a %PDF header for PDFs.

Written for commit 6897c92. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a2f44ec-fa33-4ca4-beff-504ef95a98e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-146-add-real-driver-integration-smoke-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 3349387 into develop Jun 1, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-146-add-real-driver-integration-smoke-tests branch June 1, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant