Skip to content

CONV-148: Connect convert button to CreateConversionJobAction#146

Merged
menvil merged 1 commit into
developfrom
feature/CONV-148-connect-convert-button-to-create-conversion-job-action
Jun 1, 2026
Merged

CONV-148: Connect convert button to CreateConversionJobAction#146
menvil merged 1 commit into
developfrom
feature/CONV-148-connect-convert-button-to-create-conversion-job-action

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner
  • Adds $currentConversionJobId property to DashboardConverter
  • Implements convert() method: creates ConversionJob via CreateConversionJobAction, sets step=converting
  • CONV-147 test now passes (269/269)

🤖 Generated with Claude Code


Summary by cubic

Connects the dashboard Convert button to CreateConversionJobAction so clicking Convert creates a ConversionJob, stores its ID, and moves the flow to "converting". Fulfills Linear CONV-148 and prevents duplicate job creation while a conversion is in progress.

  • New Features
    • Added currentConversionJobId to track the active conversion.
    • Implemented convert() to call CreateConversionJobAction with user, source file, target format, and options.
    • Added guards to no-op if inputs are missing or a conversion is already running.

Written for commit 4dfed27. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 8e7e0b1 into develop Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1726c53b-85c6-4bdc-bc8d-36e1fd0d07f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-148-connect-convert-button-to-create-conversion-job-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-148-connect-convert-button-to-create-conversion-job-action branch June 1, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant