Skip to content

CONV-162: Add result expired UI handling#160

Merged
menvil merged 1 commit into
developfrom
feature/CONV-162-add-result-expired-ui-handling
Jun 1, 2026
Merged

CONV-162: Add result expired UI handling#160
menvil merged 1 commit into
developfrom
feature/CONV-162-add-result-expired-ui-handling

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner
  • FileRecord::isExpired() helper added
  • FileRecordFactory::expired() state added
  • Completed state shows 'This result has expired' + no Download button when result is expired
  • 285/285 tests pass

🤖 Generated with Claude Code


Summary by cubic

Adds an expired-result state to the dashboard converter so users see a clear message and no download option when a result file is past its expiration. Aligns with Linear CONV-162 by blocking expired downloads and prompting users to re-upload.

  • New Features
    • Added FileRecord::isExpired() to check expiration via expires_at.
    • Added FileRecordFactory::expired() state for generating expired files in tests.
    • Updated completed step UI: shows “This result has expired” and hides Download; keeps “Convert another file”.
    • Added a feature test covering the expired state visibility and no-download behavior.

Written for commit b9daf0f. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 41589c4 into develop Jun 1, 2026
@menvil menvil deleted the feature/CONV-162-add-result-expired-ui-handling branch June 1, 2026 20:55
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d420b7c-45a3-47db-8dd4-b4bc7635ab27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-162-add-result-expired-ui-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant