Skip to content

CONV-246: Add billing success and cancel pages#215

Merged
menvil merged 1 commit into
developfrom
feature/CONV-246-add-billing-success-and-cancel-pages
Jun 2, 2026
Merged

CONV-246: Add billing success and cancel pages#215
menvil merged 1 commit into
developfrom
feature/CONV-246-add-billing-success-and-cancel-pages

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Auth-protected /billing/success and /billing/cancel pages
  • Views show appropriate messages without claiming plan is active (webhook confirms that)
  • Tests cover page rendering and auth protection

Test plan

  • Success page renders with "Billing successful" text
  • Cancel page renders with "Billing cancelled" text
  • Both pages require authentication
  • composer test passes (445 tests)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds feature tests for the auth-protected billing result pages (/billing/success, /billing/cancel), verifying they render the expected messages and require login. Satisfies CONV-246 by locking down access and validating copy while activation remains webhook-driven.

Written for commit b060ff3. Summary will update on new commits.

Review in cubic

Routes and views were pre-added in CONV-245 to support route()
resolution. This task adds the feature tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit c0514f6 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aed7bec4-1b5b-41c0-865d-b7bc854084f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-246-add-billing-success-and-cancel-pages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-246-add-billing-success-and-cancel-pages branch June 2, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant