Skip to content

CONV-251/252: Test and implement subscription activated handling#220

Merged
menvil merged 2 commits into
developfrom
feature/CONV-251-test-subscription-activated-updates-user-plan
Jun 2, 2026
Merged

CONV-251/252: Test and implement subscription activated handling#220
menvil merged 2 commits into
developfrom
feature/CONV-251-test-subscription-activated-updates-user-plan

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • CONV-251: Added failing tests for handleSubscriptionActivated
  • CONV-252: Implemented subscription activation — updates user.plan via forceFill using plan from BillingPlanRepository
  • Unknown plan key throws UnknownBillingPlanException
  • FeatureAccessService will see updated plan immediately via user.plan

Test plan

  • free → pro plan update on activation
  • free → max plan update on activation
  • Unknown plan key throws exception
  • composer test passes (455 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Implements subscription activation handling to update user.plan based on the billing plan key. Addresses CONV-251/CONV-252 by wiring handleSubscriptionActivated to the plan repository and covering it with tests.

  • New Features
    • handleSubscriptionActivated uses the plan repository to set user.plan (free → pro or free → max).
    • Throws UnknownBillingPlanException for invalid keys; tests cover success and error paths.

Written for commit e8dc13c. Summary will update on new commits.

Review in cubic

menvil and others added 2 commits June 2, 2026 17:47
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 85a3ba4 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce23a499-260d-4e1d-856c-89d5b225788d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-251-test-subscription-activated-updates-user-plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-251-test-subscription-activated-updates-user-plan branch June 2, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant