Skip to content

CONV-301: Add converter schema endpoint#261

Merged
menvil merged 1 commit into
developfrom
feature/CONV-301-add-converter-schema-endpoint
Jun 3, 2026
Merged

CONV-301: Add converter schema endpoint#261
menvil merged 1 commit into
developfrom
feature/CONV-301-add-converter-schema-endpoint

Conversation

@menvil

@menvil menvil commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds GET /api/v1/converters/{source}/{target}/schema returning options schema for converter pair
  • Returns 422 unsupported_conversion for invalid pairs via domain exception mapping
  • Implementation already in ConverterController::schema() from CONV-300

Test plan

  • Valid pair returns {data: {source_format, target_format, options}}
  • Unsupported pair → 422 unsupported_conversion
  • Missing API key → 401
  • composer test passes (558 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds GET /api/v1/converters/{source}/{target}/schema to return the options schema for a converter pair. Fulfills Linear CONV-301 with clear error handling and auth.

  • New Features
    • Route added to ConverterController::schema().
    • Valid pairs return data.source_format, data.target_format, and data.options.
    • Unsupported pairs return 422 with error.code = unsupported_conversion.
    • Requires API key; unauthenticated requests return 401.

Written for commit b43cab2. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit aeb9421 into develop Jun 3, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4fe527f8-10b3-4c1c-8f62-8861ca6232b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-301-add-converter-schema-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant