Skip to content

CONV-305: Add create conversion endpoint#265

Merged
menvil merged 1 commit into
developfrom
feature/CONV-305-add-create-conversion-endpoint
Jun 3, 2026
Merged

CONV-305: Add create conversion endpoint#265
menvil merged 1 commit into
developfrom
feature/CONV-305-add-create-conversion-endpoint

Conversation

@menvil

@menvil menvil commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds POST /api/v1/conversions delegating to CreateConversionJobAction
  • Returns 201 Created with status/source_format/target_format
  • 402 insufficient_credits when balance < cost
  • 403 when file not owned by API user

Test plan

  • Creates conversion job with status queued
  • Insufficient credits → 402 insufficient_credits
  • Other user's file → 403
  • Missing API key → 401
  • composer test passes (575 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds POST /api/v1/conversions to create a conversion job and return the job details. Implements auth, credit checks, and file ownership rules to meet Linear CONV-305.

  • New Features
    • POST /api/v1/conversions creates a job via CreateConversionJobAction and returns 201 with status, source_format, and target_format.
    • Validates auth, credits, and file ownership with 401, 402 (insufficient_credits), and 403 responses.
    • Feature tests cover queued job creation and all error cases.

Written for commit 6a48de3. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 063956a into develop Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 16f58fba-b54a-4d9b-8c78-901e940c8661

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-305-add-create-conversion-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant