Skip to content

CONV-307: Add conversion result download endpoint#267

Merged
menvil merged 1 commit into
developfrom
feature/CONV-307-add-conversion-result-download-endpoint
Jun 3, 2026
Merged

CONV-307: Add conversion result download endpoint#267
menvil merged 1 commit into
developfrom
feature/CONV-307-add-conversion-result-download-endpoint

Conversation

@menvil

@menvil menvil commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds GET /api/v1/conversions/{conversion}/download streaming file download
  • Checks: owner, status=completed, result file exists, not expired
  • Non-completed → 422 result_not_ready; other user → 403
  • Internal storage paths never exposed in JSON response

Test plan

  • Completed conversion with result file → 200 download
  • Queued conversion → 422 result_not_ready
  • Other user → 403
  • composer test passes (581 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds GET /api/v1/conversions/{conversion}/download to let users download completed conversion results. Streams the file and enforces ownership and completion per Linear CONV-307.

  • New Features
    • Adds GET /api/v1/conversions/{conversion}/download that streams the result file.
    • Requires ownership, completed status, and an existing, non-expired result.
    • Returns 422 result_not_ready if not complete; 403 if not owner.
    • Hides internal storage paths; adds tests for success, 422, and 403.

Written for commit b6a6395. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 165ffbfe-a86d-4d32-8f45-3f84dccf08a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-307-add-conversion-result-download-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 61a87f6 into develop Jun 3, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant