Skip to content

CONV-312: Add API foundation final smoke tests#272

Merged
menvil merged 1 commit into
developfrom
feature/CONV-312-add-api-foundation-final-smoke-tests
Jun 3, 2026
Merged

CONV-312: Add API foundation final smoke tests#272
menvil merged 1 commit into
developfrom
feature/CONV-312-add-api-foundation-final-smoke-tests

Conversation

@menvil

@menvil menvil commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Final smoke tests for Phase 19 API foundation
  • Verifies all non-model-bound endpoints require API key (401 without token)
  • Verifies health endpoint remains public
  • Verifies free user blocked by api_not_available gate
  • Verifies Pro user passes through gate
  • Cross-user model-bound access verified via ApiOwnershipGuardTest (CONV-310)
  • Dashboard web route unaffected by API layer

Test plan

  • GET /api/v1/health → 200 public
  • All 6 non-model-bound business endpoints → 401 without token
  • Free user → 403 api_not_available
  • Pro user → 200 on protected endpoints
  • Cross-user file targets → 403 forbidden
  • composer test passes (601 tests)
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds final smoke tests for the API foundation (CONV-312) to confirm auth gating and public health. Ensures non-model-bound endpoints require an API key, /api/v1/health remains public, Free users hit api_not_available, Pro users pass, and model-bound endpoints block cross-user access.

Written for commit 151e645. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c017bb4-4e02-4ab0-8608-eda452e97237

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-312-add-api-foundation-final-smoke-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 6411076 into develop Jun 3, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant