Skip to content

CONV-032: Test format normalization rules#45

Merged
menvil merged 1 commit into
developfrom
feature/CONV-032-test-format-normalization-rules
May 28, 2026
Merged

CONV-032: Test format normalization rules#45
menvil merged 1 commit into
developfrom
feature/CONV-032-test-format-normalization-rules

Conversation

@menvil

@menvil menvil commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add failing unit tests for FileFormat::normalize() (jpeg→jpg, uppercase, leading dot, unsupported format).
  • Tests intentionally red — will be closed by CONV-033 next in sequence.

Test plan

  • New tests fail as expected before CONV-033

Summary by cubic

Adds unit tests defining FileFormat::normalize() behavior. Covers jpeg→jpg, case insensitivity, stripping a leading dot, and rejecting unsupported formats. Also verifies enum values for png, jpg, webp, and pdf. Tests are red by design and will pass in CONV-033.

Written for commit 3974b57. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@menvil menvil merged commit abb03b8 into develop May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95bdbae6-ed9a-4aa2-b216-abf5cfbf911f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-032-test-format-normalization-rules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-032-test-format-normalization-rules branch May 28, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant