Skip to content

CONV-045: Implement options validation#58

Merged
menvil merged 1 commit into
developfrom
feature/CONV-045-implement-options-validation
May 28, 2026
Merged

CONV-045: Implement options validation#58
menvil merged 1 commit into
developfrom
feature/CONV-045-implement-options-validation

Conversation

@menvil

@menvil menvil commented May 28, 2026

Copy link
Copy Markdown
Owner

Implements OptionsValidator: applies defaults, enforces required fields, rejects unknown keys and disallowed values, normalizes toggle/number/color values.


Summary by cubic

Implements converter options validation to apply defaults, enforce required fields, reject unknown keys, and normalize values; invalid input now throws InvalidConverterOptionsException. Addresses Linear CONV-045.

  • New Features

    • Validates schema and rejects unknown option keys.
    • Applies defaults and enforces required fields.
    • Ensures allowed values for select/segmented inputs.
    • Normalizes toggle (bool), number/range (numeric), and color (hex) values.
    • Throws InvalidConverterOptionsException with specific failure reasons.
  • Migration

    • Update error handling to catch InvalidConverterOptionsException when validating converter options.

Written for commit 8af574f. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@menvil menvil merged commit 37fee2b into develop May 28, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b872bb9a-6b60-4816-8b40-af142d3e85e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-045-implement-options-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-045-implement-options-validation branch May 28, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant