Skip to content

CONV-050: Add PNG to PDF converter capability#66

Merged
menvil merged 1 commit into
developfrom
feature/CONV-050-add-png-to-pdf-converter-capability
May 29, 2026
Merged

CONV-050: Add PNG to PDF converter capability#66
menvil merged 1 commit into
developfrom
feature/CONV-050-add-png-to-pdf-converter-capability

Conversation

@menvil

@menvil menvil commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add PngToPdfConverter with PDF-specific options (page_size, orientation, margin, fit_mode, compression).

Test plan

  • composer test
  • composer lint

Summary by cubic

Adds a PNG to PDF converter with configurable page size, orientation, margin, fit mode, and compression. Fulfills CONV-050 and validates options with OptionsValidator.

  • New Features
    • New PngToPdfConverter (key: png:pdf) with label “PDF” and a short description.
    • Options schema with defaults: page_size (auto/A4/Letter), orientation (auto/portrait/landscape), margin (none/small/medium), fit_mode (contain/cover/original), compression (none/balanced/small).
    • Unit tests cover converter metadata and default option validation.

Written for commit bc0d38c. Summary will update on new commits.

Review in cubic

@menvil menvil merged commit 2bc382b into develop May 29, 2026
1 check passed
@menvil menvil deleted the feature/CONV-050-add-png-to-pdf-converter-capability branch May 29, 2026 11:13
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d21ba366-9cef-4bef-a37d-8d047507890c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-050-add-png-to-pdf-converter-capability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant