Skip to content

CONV-055: Add recommended target metadata#71

Merged
menvil merged 1 commit into
developfrom
feature/CONV-055-add-recommended-target-metadata
May 29, 2026
Merged

CONV-055: Add recommended target metadata#71
menvil merged 1 commit into
developfrom
feature/CONV-055-add-recommended-target-metadata

Conversation

@menvil

@menvil menvil commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Converter::isRecommended() and surface it via ConverterRegistry::targetsFor() targets.
  • PNG -> JPG and JPG -> WEBP marked as recommended.

Test plan

  • composer test
  • composer lint

Summary by cubic

Adds “recommended” metadata to conversion targets so UIs can suggest the best output. Supports Linear CONV-055 by exposing which targets we recommend (PNG→JPG, JPG→WEBP).

  • New Features

    • Added Converter::isRecommended() and surfaced it in ConverterRegistry::targetsFor().
    • PNG→JPG and JPG→WEBP now return recommended=true.
  • Migration

    • If you have custom Converter implementations, add isRecommended(): bool (return false by default).

Written for commit 8cc9706. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a7ed477d-009e-403e-9a14-ba69133d23d5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-055-add-recommended-target-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 91d442a into develop May 29, 2026
2 of 3 checks passed
@menvil menvil deleted the feature/CONV-055-add-recommended-target-metadata branch May 29, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant