Skip to content

CONV-056: Register MVP converter capabilities#72

Merged
menvil merged 1 commit into
developfrom
feature/CONV-056-register-mvp-converter-capabilities
May 29, 2026
Merged

CONV-056: Register MVP converter capabilities#72
menvil merged 1 commit into
developfrom
feature/CONV-056-register-mvp-converter-capabilities

Conversation

@menvil

@menvil menvil commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bind ConverterRegistry singleton with all six MVP converters via ConverterServiceProvider.
  • Registry returns null/empty instead of throwing for unsupported formats.
  • CONV-047 and CONV-051 placeholder tests are un-skipped and now passing.

Test plan

  • composer test
  • composer lint

Summary by cubic

Registers all six MVP image converters and binds a singleton ConverterRegistry via a new ConverterServiceProvider (CONV-056). The registry now returns []/null for unsupported formats instead of throwing.

  • New Features
    • Added ConverterServiceProvider that builds ConverterRegistry with png→jpg/webp/pdf and jpg→png/webp/pdf converters.
    • Registered the provider in bootstrap/providers.php.
    • Updated ConverterRegistry to catch unsupported formats and return []/null.

Written for commit e6f640e. Summary will update on new commits.

Review in cubic

@menvil menvil merged commit 48f7995 into develop May 29, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23179b08-cc6e-4769-b193-0d21d52927f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-056-register-mvp-converter-capabilities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-056-register-mvp-converter-capabilities branch May 29, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant