Skip to content

CONV-084: Add format step guard#91

Merged
menvil merged 1 commit into
developfrom
feature/CONV-084-add-format-step-guard
May 31, 2026
Merged

CONV-084: Add format step guard#91
menvil merged 1 commit into
developfrom
feature/CONV-084-add-format-step-guard

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-084 — Add Format Step Guard

Guards the format step so users cannot reach target-format selection without an uploaded file.

Changes

  • Add goToFormatStep() — opens format step only when a current FileRecord exists; otherwise clears stale currentFileId and returns to upload.
  • Add ensureValidStep() — defensive guard that snaps back to upload if step === 'format' but no current file.

Tests

  • Format step cannot be opened without an uploaded file.
  • Missing/stale currentFileId returns user to upload step.
  • Format step opens when a current file exists.

composer test (178), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-084 by guarding the format step so users can’t reach it without an uploaded file. Missing or stale current files now redirect back to upload.

  • Bug Fixes
    • Added goToFormatStep(): open format only if a current file exists; otherwise clear currentFileId and go to upload.
    • Added ensureValidStep(): if step is format but no current file, snap back to upload.
    • Tests cover blocking access without a file, handling stale IDs, and the valid path.

Written for commit b5ffc3d. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aacb9285-dd8b-489f-8dab-29bff08f0d1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-084-add-format-step-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 76e1787 into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-084-add-format-step-guard branch May 31, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant