Skip to content

fix: merge error PR362 - #364

Merged
mverch67 merged 1 commit into
masterfrom
mverch67-patch-merge
Aug 5, 2026
Merged

fix: merge error PR362#364
mverch67 merged 1 commit into
masterfrom
mverch67-patch-merge

Conversation

@mverch67

@mverch67 mverch67 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved ESP32 map tile requests by using the device’s current unique identifier in the HTTP User-Agent.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d50ce1d2-9cc9-452a-8bea-39464db288bd

📥 Commits

Reviewing files that changed from the base of the PR and between d5c7165 and 9cccce0.

📒 Files selected for processing (1)
  • source/graphics/map/URLService.cpp

📝 Walkthrough

Walkthrough

The ESP32 HTTP User-Agent now obtains the device identifier through MapTileSettings::getUniqueId() instead of unique_id. The ESP32 conditional-compilation terminator remains #endif.

Changes

ESP32 User-Agent update

Layer / File(s) Summary
Use the settings identifier accessor
source/graphics/map/URLService.cpp
The User-Agent construction uses MapTileSettings::getUniqueId(). The ESP32 preprocessor guard remains terminated with #endif.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops through code so neat,
The device ID now finds its seat.
Through settings it travels, clear and true,
While #endif stays in view.
Carrot cheers for the change anew!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies a merge error fix and references PR362, which relates to the small corrective change in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mverch67
mverch67 merged commit 289daf6 into master Aug 5, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant