Sony embedder moved to new org#758
Conversation
|
@FredeHoey looks good. How did you test this? |
|
Just checking the DRM EGLStream backend needs the Wayland dependency? (I've not used it so it might, just seems odd on first inspection.) |
|
@lhoward no idea. I know it’s not needed with the new IVI-homescreen drm/kms-EGL backend. |
I built all the recipes provided by both repositories with FLUTTER_ELINUX_USE_SONY = "1" FLUTTER_ELINUX_USE_SONY = "0" And with it unset, and it passed. I only use the drm gbm backend, so I haven't tested all programs at runtime, but if they worked from Sonys tree, I don't see what would have broken them in the fork.
I'll double-check when I'm back at my desk :) |
5812b19 to
c6f8f7d
Compare
It appears that it doesn't. I've also updated SRCREV to latest master. @jwinarske, I just want to note that a lot of the sony recipes don't compile under GCC 15 which is the default gcc compiler for wrynose, so if the flag is not set, the warning will possibly drown in compiler output. |
449dda1 to
c4a99ee
Compare
|
@FredeHoey if the don’t build in wrynose, they won’t build in master. Any recipe that doesn’t build will be removed. I started roll to 3.44.2 yesterday. I’ll take a look at the Sony recipes next week. Also want to compare them to the new high performance backends in IVI-homescreen. If they are dismal in comparison, likely I will drop them. |
|
@jwinarske I can kick off a build of all the original Sony recipes to see which ones don't build on master/wrynose and remove them if you want? EDIT: build came back almost all red, only the video-player-plugin from the sony recipes builds
All recipes from flutter-elinux compile green |
This includes some fixes for building with gcc
c4a99ee to
a8f2368
Compare
|
@jwinarske I just opened another merge request based off of this one, that removes the sony recipes. We can merge this one or both. Whatever you prefer :) |
|
@jwinarske Do you have any further comments for this before it can be merged? 🙏🏼 |
#740 seems stale and #741 is closed, so I'm opening this new PR to update the location of the sony embedder including warnings about deprecation of the sony recipes.
The FLUTTER_ELINUX_USE_SONY variable controls wheter or not the build uses sony's or flutter elinux's recipes.