test: rename cpu_and_cuda to all_supported_devices - #817
Merged
Conversation
This commit renames a `cpu_and_cuda()` function used for pytest device parameterization to `all_supported_devices()`. This is helpful for those who work on multi-gpu support in torchcodec as `cpu_and_cuda()` was one of the function required to be patched to allow running torchcodec tests on other devices. Rename steps out from binding function to cuda and allows to reduce the change scope to enable non-cuda devices. Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
meta-cla
Bot
added
the
CLA Signed
NicolasHug
approved these changes
Aug 15, 2025
NicolasHug
approved these changes
Aug 15, 2025
NicolasHug
left a comment
NicolasHug
left a comment
Contributor
There was a problem hiding this comment.
This sounds reasonable, thanks @dvrogozh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames a
cpu_and_cuda()function used for pytest device parameterization toall_supported_devices(). This is helpful for those who work on multi-gpu support in torchcodec ascpu_and_cuda()was one of the function required to be patched to allow running torchcodec tests on other devices. Rename steps out from binding function to cuda and allows to reduce the change scope to enable non-cuda devices.CC: @scotts, @NicolasHug, @eromomon