Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 100 100
Lines 8271 8271
=======================================
Hits 8082 8082
Misses 189 189 Continue to review full report at Codecov.
|
dmentipl
previously approved these changes
Apr 7, 2021
Contributor
dmentipl
left a comment
dmentipl
left a comment
There was a problem hiding this comment.
Looks good. I've tested this by removing parts of the licence and seeing pytest fail (otherwise it passes).
One other option (perhaps for a future PR) would be to have the licence text in a separate non-code file and read it in in the test. Then add a MANIFEST.in file to make sure it's packaged with the source code.
neilCrosswaite
approved these changes
Apr 7, 2021
dmentipl
approved these changes
Apr 7, 2021
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Add licence check inside pytest * Remove licence check from improver-tests shell script * Expand comment * Simplify licence finding code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the licence header check from
bin/improver-testsinto pytest. This avoids needing to run a separate tool for this task and also makes the licence check run as part of CI on Github Actions.Resolves #1416
Testing: