Skip to content

Pin proj and fix numpy-update-related test failures#2326

Merged
MoseleyS merged 4 commits intomasterfrom
pin-proj-9-7-1
Mar 11, 2026
Merged

Pin proj and fix numpy-update-related test failures#2326
MoseleyS merged 4 commits intomasterfrom
pin-proj-9-7-1

Conversation

@mo-AliceLake
Copy link
Contributor

@mo-AliceLake mo-AliceLake commented Mar 10, 2026

Addresses #2325

Updating proj from 9.7.1 to 9.8.0 modifies several upstream coordinate‑transformation behaviours, resulting in output changes that cause multiple IMPROVER unit tests to fail (see issue for full description).

While working on this, running latest.yml (which has numpy unpinned) pulled in a newer numpy version, which caused further test failures unrelated to proj and then needed additional fixes.

This PR therefore:

  • Pins proj to 9.7.1, the last version where all tests pass, and
  • Includes the updates needed to accommodate the newer NumPy version brought in by latest.yml.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s) - N/A

CLA

  • If a new developer, signed up to CLA

@mo-AliceLake mo-AliceLake changed the title Pinning proj to 9.7.1 Pin proj to 9.7.1 to stabilise coordinate‑transformation behaviour Mar 10, 2026
@mo-AliceLake mo-AliceLake changed the title Pin proj to 9.7.1 to stabilise coordinate‑transformation behaviour Pin proj to 9.7.1 to stabilise coordinate‑transformation behaviour + update numpy Mar 11, 2026
@mo-AliceLake mo-AliceLake changed the title Pin proj to 9.7.1 to stabilise coordinate‑transformation behaviour + update numpy Pin proj and fix numpy-update-related test failures Mar 11, 2026
@gavinevans gavinevans self-assigned this Mar 11, 2026
gavinevans
gavinevans previously approved these changes Mar 11, 2026
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-AliceLake 👍

@gavinevans gavinevans assigned MoseleyS and unassigned gavinevans Mar 11, 2026
@MoseleyS MoseleyS merged commit 9bbbf7a into master Mar 11, 2026
7 checks passed
@mo-AliceLake mo-AliceLake deleted the pin-proj-9-7-1 branch March 11, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants