Creating new nowcast forecasting module for creating advected forecasts and precipitation accumulations#836
Merged
gavinevans merged 1 commit intometoppv:masterfrom Apr 4, 2019
Conversation
MoseleyS
approved these changes
Apr 4, 2019
Member
MoseleyS
left a comment
MoseleyS
left a comment
There was a problem hiding this comment.
I am satisfied that the class AdvectField has been copied without changes and the unit test files renamed to match.
All tests pass (eventually)
gavinevans
approved these changes
Apr 4, 2019
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @fionaRust 👍
These changes seem fine to me.
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First move AdvectField plugin into new module. No changes to functionality
Addresses #663 IMPRO-898
Testing: