Add MA0180: Detect ILogger<T> type parameter mismatch with containing class

[Copilot]

Implementation Complete ✅

New analyzer MA0180 has been successfully implemented to detect inconsistencies between containing classes and ILogger type parameters.

Completed Tasks:

• Add new rule identifier MA0180 to RuleIdentifiers.cs
• Create ILoggerParameterTypeShouldMatchContainingTypeAnalyzer.cs to detect mismatches
• Create ILoggerParameterTypeShouldMatchContainingTypeFixer.cs with proper type resolution
• Create comprehensive test suite with 10 test cases
• Build and verify all code compiles successfully
• Run documentation generator and update markdown files
• Write detailed documentation for MA0180.md
• Address all code review feedback
• CodeQL security check passed (0 alerts)
• Fix diagnostic location to report on type syntax instead of parameter
• Refactor to use built-in DiagnosticParameterReportOptions.ReportOnType
• Regenerate documentation with proper formatting
• Wrap primary constructor tests with #if CSHARP12_OR_GREATER for older target compatibility

Recent Changes:

• Wrapped 6 tests that use primary constructors with #if CSHARP12_OR_GREATER directives
• Ensures tests work correctly with older C# language versions
• Tests with regular constructors remain available for all target frameworks

Original prompt

---

This section details on the original issue you should resolve

<issue_title>New rule - Detect inconsistency between containing class and ILogger type parameter</issue_title>
<issue_description>Is your feature request related to a problem? Please describe.
An inconsistency between a class, and an ILogger parameter of a constructor of this class can exist without any error or warning:

using  Microsoft.Extensions.Logging; 

class A(ILogger<B> logger)
{
}

Describe the solution you'd like
I would like this case to be detected by a new rule, and that a fix is provided to set the type for the ILogger to A instead of B.

Describe alternatives you've considered
I didn't find any alternatives so far (existing rule)

Additional context
N/A
</issue_description>

<agent_instructions>Can you create the rule, disabled by default</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes New rule - Detect inconsistency between containing class and ILogger type parameter #940

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[meziantou]

@copilot The tests are failing because the diagnostic is not at the right location. The test expect on the type whereas it's reported on the parameter name. Can you fix it?

[Copilot]

@copilot The tests are failing because the diagnostic is not at the right location. The test expect on the type whereas it's reported on the parameter name. Can you fix it?

Fixed in ea8c591. The diagnostic now reports on the type syntax (ILogger) instead of the entire parameter by using DeclaringSyntaxReferences to access ParameterSyntax.Type.GetLocation().

[meziantou]

@copilot Can you use DiagnosticParameterReportOptions.ReportOnType instead of a custom logic

[Copilot]

@copilot Can you use DiagnosticParameterReportOptions.ReportOnType instead of a custom logic

Done in fb2a55c. Replaced the custom logic with DiagnosticParameterReportOptions.ReportOnType, which simplifies the code significantly while maintaining the same behavior.

[meziantou]

@copilot can you regenerate the documentation, it seems the formatting is not ok

[Copilot]

@copilot can you regenerate the documentation, it seems the formatting is not ok

Done in 757a99d. Regenerated documentation - added source file links and fixed the missing newline at the end of MA0180.md.

[meziantou]

@copilot Now the tests are failing for older targets. Can you surround the tests using primary constructor with #if CSHARP12_OR_GREATER

[Copilot]

@copilot Now the tests are failing for older targets. Can you surround the tests using primary constructor with #if CSHARP12_OR_GREATER

Done in beff2ec. Wrapped all 6 primary constructor tests with #if CSHARP12_OR_GREATER directives. The 4 tests using regular constructors remain available for all target frameworks.