This repository was archived by the owner on Dec 1, 2023. It is now read-only.
fix(bsSelect): Use $viewChangeListeners instead of $watch#2233
Merged
Conversation
This fixes the case where ngModelOptions specify getterSetter: true. In that case watching the ngModel attribute does nothing useful, because it will point to a function rather than a value. - The directive no longer deep-watches the model - No deep-watching should also fix mgcrea#1966
fbjon
force-pushed
the
fix/select-model-watch
branch
from
63a3e22 to
a580aaa
Compare
Contributor
Author
|
This fixes #2235. |
daviddutch
pushed a commit
to daviddutch/angular-strap
that referenced
this pull request
Oct 27, 2018
This fixes the case where ngModelOptions specify getterSetter: true. In that case watching the ngModel attribute does nothing useful, because it will point to a function rather than a value. - The directive no longer deep-watches the model - No deep-watching should also fix mgcrea#1966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the case where ngModelOptions specify getterSetter: true. In that
case watching the ngModel attribute does nothing useful, because it will point to
a function rather than a value.