Skip to content

Update mrml to 5.0.0#37

Merged
mgd020 merged 10 commits into
masterfrom
mrml-v5.0.0
Mar 18, 2025
Merged

Update mrml to 5.0.0#37
mgd020 merged 10 commits into
masterfrom
mrml-v5.0.0

Conversation

@mgd020
Copy link
Copy Markdown
Owner

@mgd020 mgd020 commented Mar 18, 2025

Updates:

  • mrml@5.0.0
  • maturin@1.8.3
  • actions/upload-artifact@v4
  • actions/download-artifact@v4

Supersedes #35 & #36

@mgd020 mgd020 changed the title Update mrml to 5.0.0 and maturin to 1.8.3 Update mrml to 5.0.0 Mar 18, 2025
@mgd020 mgd020 merged commit 86aa14c into master Mar 18, 2025
@mgd020 mgd020 deleted the mrml-v5.0.0 branch March 18, 2025 12:13
@federicobond
Copy link
Copy Markdown

Hi @mgd020! Thank you so much for this library; we have been using it in production for months without any problems.

This is just a heads-up that updating mrml to 5.x was a breaking change for us, and we let our guard down a bit because it was only a patch release in mjml-python. In the future, it may be useful to match the bump in the mrml crate version to better communicate the potential impact of changes.

@mgd020
Copy link
Copy Markdown
Owner Author

mgd020 commented Mar 29, 2025

This is just a heads-up that updating mrml to 5.x was a breaking change for us, and we let our guard down a bit because it was only a patch release in mjml-python. In the future, it may be useful to match the bump in the mrml crate version to better communicate the potential impact of changes.

I'm sorry to hear that! You are of course right, I should have bumped major.

Can you elaborate on any breaking changes? I would like to document them in the release notes.

@federicobond
Copy link
Copy Markdown

federicobond commented Mar 29, 2025

I can't seem to reproduce it now, but it related to ending tag handling. An mj-button inside an mj-wrapper inside an mj-text used to render as a button despite being technically against the spec. The new version now (correctly) outputs the HTML inside the mj-text as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants