remove deprecated/broken OptionsWithFallback#unique_type#435
Merged
mhenrixon merged 2 commits intomhenrixon:masterfrom Mar 21, 2020
Merged
remove deprecated/broken OptionsWithFallback#unique_type#435mhenrixon merged 2 commits intomhenrixon:masterfrom
mhenrixon merged 2 commits intomhenrixon:masterfrom
Conversation
mhenrixon
approved these changes
Oct 17, 2019
Owner
mhenrixon
left a comment
mhenrixon
left a comment
There was a problem hiding this comment.
Yup, it should totally be removed for v7! Thank you for your contribution 👍
Owner
|
Thanks a bunch for the contribution! I will backport the fix for v6 |
This was referenced Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enqueuing a job, the client middleware continues to view
sidekiq_options unique: :until_executedas valid, and inserts a lock for the job. However, the Locksmith does not look at the deprecatedunique_typemethod (only theLOCKkey), so when running the lock.lua script, the conditional that should unlock upon completion (if lock == "until_expired" and ttl then ...) is never executed.Discovered on version 6.0.15 (
earlier 6.0.x releases have this issue as welledit: appears to have been introduced in 6.0.15), and though 7.0.0.beta2 has been considerably refactored, it still appears to be an issue.Given that
uniquewas deprecated as of 6.0 in favor oflock, it seems best to remove it entirely.