fix(ci): allow tests to run in docker#805
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom Aug 17, 2023
Earlopain:test-improvements
Merged
fix(ci): allow tests to run in docker#805mhenrixon merged 2 commits intomhenrixon:mainfrom Earlopain:test-improvements
mhenrixon merged 2 commits intomhenrixon:mainfrom
Earlopain:test-improvements
Conversation
mhenrixon
approved these changes
Aug 17, 2023
Contributor
Author
|
Wow, that was fast (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't run the tests locally but in a docker compose setup, the hardcoded uris don't work well with that. Allow overriding them through env variables but fall back to the localhost ones.
Also make CI green by fixing rubocop violations.