Prevent Jobs from deleting mutexes they don't own#96
Merged
mhenrixon merged 1 commit intomhenrixon:masterfrom Jul 30, 2015
Merged
Prevent Jobs from deleting mutexes they don't own#96mhenrixon merged 1 commit intomhenrixon:masterfrom
mhenrixon merged 1 commit intomhenrixon:masterfrom
Conversation
* uses jid for redis mutex to prevent deletion of a mutex owned by another job after key expire.
Owner
There was a problem hiding this comment.
Great idea using LUA for this!
This was referenced Jul 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello - so this should solve #94. The jid should already be sufficiently unique for each job and both server and client middleware have access to this.
Using the LUA script would be preferable since it saves a back-and-forth trip to the server, but if there users of sidekiq-unique-jobs with old versions of redis -- perhaps it would make sense to use the conn.watch version by default. (It's included for the tests anyways since mock-redis does not support lua scripts).