Use dataclasses instead of TypedDicts for response classes#112
Merged
Conversation
miaucl
previously approved these changes
Jan 5, 2025
Owner
miaucl
left a comment
miaucl
left a comment
There was a problem hiding this comment.
Was bringt syrupy als vorteil? So komplex sind unsere Sachen hier ja nicht 😅
Collaborator
Author
Das ist pure Faulheit meinerseits 😂 |
Signed-off-by: tr4nt0r <4445816+tr4nt0r@users.noreply.github.com>
miaucl
approved these changes
Jan 11, 2025
tr4nt0r
added a commit
that referenced
this pull request
Mar 16, 2025
Use dataclasses instead of TypedDicts as response classes Signed-off-by: tr4nt0r <4445816+tr4nt0r@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor response classes to utilize dataclasses. Mashumaro is used for serialization of json responses