Skip to content

Add support for create, delete and import templates (recipes) in Bring#154

Merged
tr4nt0r merged 3 commits intomainfrom
recipes
Feb 13, 2025
Merged

Add support for create, delete and import templates (recipes) in Bring#154
tr4nt0r merged 3 commits intomainfrom
recipes

Conversation

@tr4nt0r
Copy link
Collaborator

@tr4nt0r tr4nt0r commented Feb 11, 2025

  • Adds methods create_template for creating recipes and templates in Bring
  • Adds method delete_template for deleting recipes and templates from Bring
  • Adds method parse_recipe for parsing a recipe from an URL into a template

@tr4nt0r tr4nt0r added the 🚀 feature New feature or request label Feb 11, 2025
@tr4nt0r tr4nt0r requested a review from miaucl as a code owner February 11, 2025 01:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes missing coverage. Please review.

Project coverage is 93.23%. Comparing base (90215ed) to head (c5cc4fb).

Files with missing lines Patch % Lines
bring_api/bring.py 56.52% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   94.04%   93.23%   -0.82%     
==========================================
  Files           6        6              
  Lines         588      665      +77     
  Branches       31       31              
==========================================
+ Hits          553      620      +67     
- Misses         27       37      +10     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miaucl
miaucl previously approved these changes Feb 11, 2025
miaucl and others added 2 commits February 11, 2025 17:41
* Fix type in `BringUserListSettingEntry` (#123)

* Revert "Fix type in `BringUserListSettingEntry` (#123)"

This reverts commit 1ac1eba.

---------

Co-authored-by: Manu <4445816+tr4nt0r@users.noreply.github.com>
@tr4nt0r tr4nt0r force-pushed the recipes branch 3 times, most recently from 578b88d to fc666a4 Compare February 11, 2025 21:32
@tr4nt0r tr4nt0r changed the title Add methods for parsing, creating and deleting recipes Add support for recipes and templates Feb 11, 2025
@tr4nt0r tr4nt0r changed the title Add support for recipes and templates Add support for create, delete and import templates (recipes) in Bring Feb 11, 2025
@tr4nt0r tr4nt0r requested a review from miaucl February 11, 2025 21:38
@tr4nt0r tr4nt0r merged commit 5b99c9f into main Feb 13, 2025
30 checks passed
@tr4nt0r tr4nt0r deleted the recipes branch February 13, 2025 12:20
tr4nt0r added a commit that referenced this pull request Mar 16, 2025
#154)

* Revert 123 fix typing (#125)

* Fix type in `BringUserListSettingEntry` (#123)

* Revert "Fix type in `BringUserListSettingEntry` (#123)"

This reverts commit 1ac1eba.

---------

Co-authored-by: Manu <4445816+tr4nt0r@users.noreply.github.com>

* Add methods for parsing, creating and deleting recipes

* rename to template

---------

Co-authored-by: Cyrill Raccaud <miaucl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants