Customize border opacity following the dash background value.

[mankurt]

Dock border should get same opacity as the rest of the dock, it would look much better IMHO.

[redianthus]

Which border are you talking about ? I don't see any border:

[mankurt]

[redianthus]

Ah yep, you're right, I tried with 0% opacity and saw the border, my bad !

[redianthus]

As a workaround, you can edit the file:

~/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/stylesheet.css

On line 4 you should have something like this:

border:1px;

Just replace it with:

border:0px;

Then disable/enable the extension.

Result:

[mankurt]

Will do, thanks mate!

[redianthus]

You're welcome.

@micheleg: I guess a better way to fix this would be to add a new line after line 84 to set border-color with the same value than background-color ; but idk if everyone would like this feature, so, it means adding a GUI option but I don't know the extension well enough to propose a patch...

[micheleg]

I guess it would make sense to set the same opacity value used for the bakground to the border as well. From a very quick test it seems this should work. It should not be too complicated, it's a matter of extending the code which retrieve and update the background color for the border too. The relevant code is in https://github.com/micheleg/dash-to-dock/blob/master/theming.js if someone wants to propose a patch.

[redianthus]

I'll propose a patch next week.

[franglais125]

I took the liberty of looking into this and prepared a patch. franglais125@0393fb9

It's in fact just two lines. I use the same information from the background colour to set the border colour.
The only thing left after that is to take care of the shadow, if not there is a shift in colour on the border.

[micheleg]

@franglais125 why do we need to set the 'box-shadow' property? Beside this, I was initially thinking of reading the actual border color and only apply the opacity to it, but this is a good first step.

[franglais125]

Ah, I see what you mean... I just re-read previous comments. I thought the point was to apply the same color, not the same opacity!

To apply the same color, I needed to remove the shadow-box, because it was making the color darker.

I can re-do the patch, assuming we want to set the opacity, and not the color to be the same?

[micheleg]

Yes, my initial idea was to apply only the opacity and keep the colour the theme author chose, but I haven't tested in real cases what would be better. In any case, retrieving and storing the border opacity is a bit more tedious but it should be easy following what is done for the background.

[franglais125]

So I re-worked the patch... franglais125@f4e5ced

One thing to note that is different to the background color is that there might be a maximum opacity for the border (Line 107 of the patch). Say the theme has borders that have a 50% opacity, should we respect this?

The first time I tried it, when setting the opacity to 100% (and if the border follows this), then it can be a bit weird. However, if there is a maximum opacity (set by the theme), then it can look more natural. But this is up to you, how you think is best!

The other doubt I have is for Line 124: does the side matter? In my test, it didn't, but I don't know if this is the same for everyone.

Cheers