Remove StartTime-ms metadata tag from cameras#279
Merged
marktsuchida merged 1 commit intomainfrom Oct 27, 2022
Merged
Conversation
In most cameras, this tag contained the value of `GetCurrentMMTime()` at the beginning of sequence acquisition. That value is milliseconds since 2000-01-01 UTC, plus an offset dependent on the current time zone. The utility of this tag is therefore not clear: it is not documented anywhere, its interpretation is complicated, and there is no evidence that it has ever been used in MMStudio or its plugins. If we ever find a need for recording the time of start of acquisition, it is better to add a tag in MMCore so that all cameras have it, not just the ones that happened to copy-paste program this tag.
Member
Author
|
See this previous comment for some more details. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cameras, this tag contained the value of
GetCurrentMMTime()at the beginning of sequence acquisition. That value is milliseconds since 2000-01-01 UTC, plus an offset dependent on the current time zone.The utility of this tag is therefore not clear: it is not documented anywhere, its interpretation is complicated, and there is no evidence that it has ever been used in MMStudio or its plugins.
If we ever find a need for recording the time of start of acquisition, it is better to add a tag in MMCore so that all cameras have it, not just the ones that happened to copy-paste program this tag.