Make MMTime data members private#280
Merged
marktsuchida merged 2 commits intomainfrom Oct 26, 2022
Merged
Conversation
This member function has never been used for serialization (in the marshaling sense). Let's remove it now in the interest of clustering source-incompatible changes to MMTime in a short time period. Since the only uses were for debug logging, they could be replaced with the new toString().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can change the internal representation without affecting user code.
Fortunately only 1 device adapter (XIMEA) needed small changes.