Move ImageMetadata.h from MMDevice to MMCore#845
Merged
marktsuchida merged 4 commits intomicro-manager:mainfrom Feb 19, 2026
Merged
Move ImageMetadata.h from MMDevice to MMCore#845marktsuchida merged 4 commits intomicro-manager:mainfrom
marktsuchida merged 4 commits intomicro-manager:mainfrom
Conversation
marktsuchida
force-pushed
the
move-image-metadata
branch
from
5c40b84 to
16527be
Compare
Retire the Metadata class (and associated tag and exception classes)
from MMDevice. The API (with excpetion throwing and unnecessary member
functions) is not suitable for device use, and we have replaced it with
MM::CameraImageMetadata.
Keep it in MMCore (presumably where it originally resided, a very long
time ago), where it is part of the MMCore API.
Move unit tests involving Metadata to MMCore:
- MMCore ImageMetadata-Tests.cpp renamed to ImageMetadataTags-Tests.cpp
- MMDevice Metadata-Tests.cpp split into
- MMDevice CameraImageMetadata-Tests.cpp
- MMCore ImageMetadata-Tests.cpp
(Assisted by Claude Code; any errors are mine.)
marktsuchida
force-pushed
the
move-image-metadata
branch
from
109b33c to
60efe92
Compare
marktsuchida
force-pushed
the
move-image-metadata
branch
from
cc8cbb9 to
95a13aa
Compare
MMDEVICE_* -> MMCORE_*, move the latter to a new common header, and switch to C++14 [[deprecated]] for deprecation.
marktsuchida
force-pushed
the
move-image-metadata
branch
from
95a13aa to
6169efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #797.
Use of the ImageMetadata.h classes in MMDevice and the device adapters have been replaced by MM::CameraImageMetadata (#843).
ImageMetadata.h remains part of the MMCore API.
Among other things, this allows independent evolution of the device interface and the MMCore API.
mainafter Devices: Replace Metadata with MM::CameraImageMetadata #843 is merged