Fix WebUSB serial#55
Merged
Merged
Conversation
Otherwise it would interfere with the flashing process
microbit-grace
requested review from
microbit-matt-hillsdon
and removed request for
microbit-matt-hillsdon
microbit-grace
changed the title
This was referenced Apr 2, 2025
Merged
Deploying microbit-connection with
|
| Latest commit: |
6328124
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb4305ef.microbit-connection.pages.dev |
| Branch Preview URL: | https://fix-serial.microbit-connection.pages.dev |
microbit-grace
commented
Apr 2, 2025
Comment on lines
+486
to
+489
| // Prevent starting serial when flashing. | ||
| if (!this.flashing) { | ||
| this.startSerialInternal(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This prevents serial from starting when flashing is in progress in the Python Editor. Adding event listener in device hook in the python editor causes serial to get started in the flashing process.
microbit-grace
commented
Apr 2, 2025
microbit-grace
changed the title
microbit-grace
added a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
Apr 2, 2025
Update connection library to include fix from microbit-foundation/microbit-connection#55
microbit-grace
added a commit
to microbit-foundation/ml-trainer
that referenced
this pull request
Apr 2, 2025
Update connection library to include fix from microbit-foundation/microbit-connection#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue fixed: microbit-foundation/python-editor-v3#1209
To test changes in Python Editor
Draft PR: microbit-foundation/python-editor-v3#1211
Preview url: https://review-python-editor-v3.microbit.org/fix-serial/
To test changes in CreateAI
Draft PR: microbit-foundation/ml-trainer#593
Preview url: https://review-createai.microbit.org/update-conn-lib/