Add warning diagnostic for V2 API use#35
Merged
Conversation
We plan to filter these out on the client based on connected device version.
5e3b106 to
5bd4ab9
Compare
1 task
…right into version-warning-2
microbit-robert
approved these changes
May 23, 2024
microbit-robert
left a comment
There was a problem hiding this comment.
LGTM. Works well. One comment to remove an outdated comment.
microbit-matt-hillsdon
pushed a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
May 23, 2024
Updates Pyright to a version with the changes from microbit-foundation/pyright#35 and conditionally hides the new messages depending on the connected device. A new setting can hide the messages. The setting can be flipped from a CodeMirror diagnostic action. See https://microbit-global.monday.com/boards/1125389526/views/244984/pulses/1434825789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #33
I've tried to pull the logic into checker.ts which feels more suitable for a high-level check.
Test data (I think the key parts of this are now in the automated tests):